Download Install Tutorial Docs FAQ Tools WikiLicense Team IRC Planet Involvement Shop Book

Changeset 1325

Show
Ignore:
Timestamp:
09/02/06 18:24:31
Author:
fumanchu
Message:

Fix for #548 (Rename the before_main hook to before_handler and MainTool? to HandlerTool?).

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/cherrypy/_cprequest.py

    r1321 r1325  
    336336     
    337337    hookpoints = ['on_start_resource', 'before_request_body', 
    338                   'before_main', 'before_finalize', 
     338                  'before_handler', 'before_finalize', 
    339339                  'on_end_resource', 'on_end_request', 
    340340                  'before_error_response', 'after_error_response'] 
     
    525525                        self.process_body() 
    526526                     
    527                     self.hooks.run('before_main') 
     527                    self.hooks.run('before_handler') 
    528528                    if self.handler: 
    529529                        self.handler() 
     
    618618        """Attach bare hooks declared in config.""" 
    619619        # Use split again to allow multiple hooks for a single 
    620         # hookpoint per path (e.g. "hooks.before_main.1"). 
     620        # hookpoint per path (e.g. "hooks.before_handler.1"). 
    621621        # Little-known fact you only get from reading source ;) 
    622622        hookpoint = k.split(".", 1)[0] 
  • trunk/cherrypy/_cpserver.py

    r1316 r1325  
    5757     
    5858    def quickstart(self, server=None): 
    59         """Main function for quick starts. MUST be called from the main thread. 
     59        """Start from defaults. MUST be called from the main thread. 
    6060         
    6161        This function works like CherryPy 2's server.start(). It loads and 
  • trunk/cherrypy/_cptools.py

    r1322 r1325  
    9595 
    9696 
    97 class MainTool(Tool): 
     97class HandlerTool(Tool): 
    9898    """Tool which is called 'before main', that may skip normal handlers. 
    9999     
     
    103103     
    104104    def __init__(self, callable, name=None): 
    105         Tool.__init__(self, 'before_main', callable, name) 
     105        Tool.__init__(self, 'before_handler', callable, name) 
    106106     
    107107    def handler(self, *args, **kwargs): 
     
    228228 
    229229 
    230 class WSGIAppTool(MainTool): 
     230class WSGIAppTool(HandlerTool): 
    231231    """A tool for running any WSGI middleware/application within CP. 
    232232     
     
    249249        # Keep request body intact so the wsgi app can have its way with it. 
    250250        cherrypy.request.process_request_body = False 
    251         MainTool._setup(self) 
    252  
    253  
    254 class SessionAuthTool(MainTool): 
     251        HandlerTool._setup(self) 
     252 
     253 
     254class SessionAuthTool(HandlerTool): 
    255255     
    256256    def _setargs(self): 
     
    274274        """Hook caching into cherrypy.request.""" 
    275275        conf = self._merged_args() 
    276         cherrypy.request.hooks.attach('before_main', self._wrapper, **conf) 
     276        cherrypy.request.hooks.attach('before_handler', self._wrapper, **conf) 
    277277 
    278278 
     
    300300default_toolbox.err_redirect = ErrorTool(cptools.redirect) 
    301301default_toolbox.etags = Tool('before_finalize', cptools.validate_etags) 
    302 default_toolbox.decode = Tool('before_main', encoding.decode) 
     302default_toolbox.decode = Tool('before_handler', encoding.decode) 
    303303default_toolbox.encode = Tool('before_finalize', encoding.encode) 
    304304default_toolbox.gzip = Tool('before_finalize', encoding.gzip) 
    305 default_toolbox.staticdir = MainTool(static.staticdir) 
    306 default_toolbox.staticfile = MainTool(static.staticfile) 
     305default_toolbox.staticdir = HandlerTool(static.staticdir) 
     306default_toolbox.staticfile = HandlerTool(static.staticfile) 
    307307# _sessions.init must be bound after headers are read 
    308308default_toolbox.sessions = SessionTool('before_request_body', _sessions.init) 
    309309default_toolbox.xmlrpc = XMLRPCTool() 
    310310default_toolbox.wsgiapp = WSGIAppTool(_wsgiapp.run) 
    311 default_toolbox.caching = CachingTool('before_main', _caching.get, 'caching') 
     311default_toolbox.caching = CachingTool('before_handler', _caching.get, 'caching') 
    312312default_toolbox.expires = Tool('before_finalize', _caching.expires) 
    313313default_toolbox.tidy = Tool('before_finalize', tidy.tidy) 
  • trunk/cherrypy/test/test_core.py

    r1321 r1325  
    139139        if not getattr(cherrypy.request, "login", None): 
    140140            raise cherrypy.InternalRedirect("/internalredirect/login") 
    141     tools.login_redir = _cptools.Tool('before_main', login_redir) 
     141    tools.login_redir = _cptools.Tool('before_handler', login_redir) 
    142142     
    143143    def redir_custom(): 

Hosted by WebFaction

Log in as guest/cpguest to create tickets