Changeset 1706

Timestamp:

08/22/07 01:02:00

Author:

fumanchu

Message:

Fix for #716 (Checker should warn on unknown tool).

Files:

• branches/cherrypy-3.0.x/cherrypy/_cpchecker.py (modified) (2 diffs)
• branches/cherrypy-3.0.x/cherrypy/test/checkerdemo.py (modified) (1 diff)

branches/cherrypy-3.0.x/cherrypy/_cpchecker.py

@@ -156 +156 @@
-                    if len(atoms) > 1:
-                        if atoms[0] not in ns:
+                            # Spit out a special warning if a known
+                            # namespace is preceded by "cherrypy."
-                            if (atoms[0] == "cherrypy" and atoms[1] in ns):
-                                msg = ("The config entry %r is invalid; "
@@ -165 +167 @@
-                                       "section: [%s]" % (k, atoms[0], section))
-                            warnings.warn(msg)
+                        elif atoms[0] == "tools":
+                            if atoms[1] not in dir(cherrypy.tools):
+                                msg = ("The config entry %r may be invalid, "
+                                       "because the %r tool was not found.\n"
+                                       "section: [%s]" % (k, atoms[1], section))
+                                warnings.warn(msg)
-    
-    def check_config_namespaces(self):

branches/cherrypy-3.0.x/cherrypy/test/checkerdemo.py

@@ -36 +36 @@
-            # Warn on mismatched types
-            '/conftype': {'request.show_tracebacks': 14},
+            # Warn on unknown tool.
+            '/web': {'tools.unknown.on': True},
-            }
-    cherrypy.quickstart(Root(), config=conf)