Ticket #307 (defect)
Opened 3 years ago
Last modified 3 years ago
_cperror.InternalError should be replaced by HTTPError(500, msg)
Status: closed (fixed)
| Reported by: | fumanchu | Assigned to: | mikerobi |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.1-rc2 |
| Component: | CherryPy code | Keywords: | |
| Cc: |
InternalError? is only used by _cputil, and then only in 2 cases. It would be better to get rid of InternalError? completely, and raise HTTPError(500, msg) instead (so that pretty HTML is output).
Change History
09/18/05 14:29:18: Modified by mikerobi
09/20/05 17:22:21: Modified by mikerobi
- owner changed from rdelon to mikerobi.
- status changed from new to assigned.
- milestone changed from 2.1-final to 2.1-rc2.
10/03/05 02:24:55: Modified by fumanchu
- status changed from assigned to closed.
- resolution set to fixed.
Fixed in [707].
This will currently get turned into a 500 error by the default _cpOnError, butI agree with fumanchu, we should only use HTTPErrors. But where do we draw line and decide which errors should get passed on to cpOnError. Making this change only makes sense if we turn all exceptions raised by the server into http errors and if _cpOnError only handles exceptions raised by the application's page handler.