Ticket #310 (defect)
Opened 3 years ago
Last modified 3 years ago
Remove XML prolog from CP error pages
Status: closed (fixed)
| Reported by: | deelan | Assigned to: | mikerobi |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.1-rc2 |
| Component: | CherryPy code | Keywords: | |
| Cc: |
Error pages sould not start with the XML prolog <xml ...> since IE6/win tries to parse them as an XML file... and fails miserably. ;(
BTW, XML prolog isn't needed at all by XHTML (see http://tantek.com/XHTML/Test/minimal.html)
Bonus feature: trackback should be HTML-escaped before sending it to the browser -- i've have funny looking trackbacks caused by non-escaped HTML elements.
thanks
Attachments
Change History
09/22/05 16:22:35: Modified by mikerobi
- owner changed from rdelon to mikerobi.
- status changed from new to assigned.
09/29/05 19:13:41: Modified by union@stvor.net
- attachment patch310 added.
09/29/05 19:14:56: Modified by union@stvor.net
Attached is a trivial patch that escapes tracebacks and messges (that can contain html aswell)
I also removed <?xml ...> and replaced it with <meta> tag for specifying encoding.
Thanks to fumanchu on irc for all the help and sugjestions.
09/30/05 00:37:41: Modified by fumanchu
- status changed from assigned to closed.
- resolution set to fixed.
Fixed in changeset [694].


patch (svn diff > patch)