Ticket Navigation

Ticket #547 (defect)

Opened 2 years ago

Last modified 2 years ago

[PATCH] serve_file still uses contentType instead of content_type

Status: closed (fixed)

Reported by:	michele	Assigned to:	rdelon
Priority:	normal	Milestone:	3.0
Component:	CherryPy code	Keywords:
Cc:

Just to be sure CP3 is consistent and uses lower_case_with_underscore everywhere, I will provide other patches if I find other offenders... ;-)

Attachments

serve_file.patch (3.3 kB) - added by michele on 08/12/06 05:03:36.: the patch
last_to_lower_case.patch (3.8 kB) - added by michele on 08/13/06 04:46:46.: Last things, just wsgiApp to wsgi_app

Change History

08/12/06 05:03:36: Modified by michele

attachment serve_file.patch added.

the patch

08/12/06 11:40:14: Modified by fumanchu

status changed from new to closed.
resolution set to fixed.

Fixed in [1242], and all others you could possibly want to change done in [1243]. ;)

08/12/06 11:55:25: Modified by michele

cc set to fumanchu@amor.org.

Cool, thanks fumanchu! ;-)

My swiss knife [1] still reveals some offenders I'm sure many are related to python internals libraries and not exposed APIs, at a first sight it seems wsgiApp inside _cpwsgi.py should be changed, if you're interested tomorrow I can cook up another patch to iron out the remaining things.

[1] egrep '\b([a-z]\w+[A-Z]+\w+)' *.py lib/*.py

08/13/06 04:46:46: Modified by michele

attachment last_to_lower_case.patch added.

Last things, just wsgiApp to wsgi_app

08/18/06 14:20:20: Modified by michele

cc deleted.

The patch is not needed anymore since wsgiApp has been removed. ;-)