Download Install Tutorial Docs FAQ Tools WikiLicense Team IRC Planet Involvement Shop Book

Ticket #567 (enhancement)

Opened 2 years ago

Last modified 2 years ago

Backport trunk bugfixes to CP 2.2, 2.1

Status: closed (fixed)

Reported by: fumanchu Assigned to: fumanchu
Priority: normal Milestone: 2.2.2
Component: CherryPy code Keywords:
Cc:

Change History

09/27/06 03:43:24: Modified by lawouach

All of them?

09/27/06 14:02:48: Modified by fumanchu

No, not all. Part of this ticket is deciding which ones are feasible. :)

10/12/06 16:17:04: Modified by lawouach

I was browsing http://www.cherrypy.org/report/6 and I do wonder which bugfixes we should backport. Some seem to require such a big work that they would mean rewriting part of CP2 (which would lead to CP3 bis :)), others look irrelevant.

However maybe #570, #256, #569, #538, #542, #579 and maybe #537 ought to be fixed in C2.2.1 but are not critical if people start moving to CP3 (which would happen quickly if TG moves rapidly to CP3).

Thoughts?

10/12/06 16:29:38: Modified by lawouach

Fixed #569.

I looked ta #538 and it seems it would require quite a lot of work.

10/12/06 16:37:16: Modified by lawouach

Fixed #542

10/12/06 16:40:22: Modified by lawouach

#579 is in fact irrelevant because in CP2 the query_string would never be set internally to None.

10/13/06 03:20:54: Modified by elvelind grandin

Regarding TG moving to CP3. this wont happend for a while. we are focusing on releasing 1.0 now so CP3 will go into 1.1.

12/10/06 14:40:18: Modified by fumanchu

  • owner changed from rdelon to fumanchu.
  • status changed from new to assigned.

I'm working my way through the changesets from [1047] to [1479], and backporting all bugfixes. I'm also adding any new features which do not change the existing 2.2 API (although they might extend that API via additional function args or module globals). At the moment, I'm on [1200]. After that, I'll go through all the tickets and see if I missed anything.

Then, if there's time and interest, we can address 2.1. But I don't think there will be much interest.

12/11/06 17:17:38: Modified by fumanchu

Okay, initial run through the changesets is done. Here's the ones I skipped because I think they need some discussion:

  • [1111] tree.mount now strips trailing slash on script_name.
  • [1166] Added support for RFC 2047 encoding and decoding of header values, and [1168] encode_TEXT only for HTTP/1.1 response headers, and verify folded response headers start with linear whitespace, and [1200] Moved RFC 2047 encoding into http.HeaderMap?. Changed HeaderMap?.sorted_list to HeaderMap?.output (which does not sort).
  • [1175] Fix for #528 (Allow request body parsing for methods other than "POST" and "PUT").
  • [1187] Fix for #538 (Caching must set Age response header).
  • [1220] Fix for #438 (autoreload.py: Server fails to start if a .pyc is imported with no corresponding .py).
  • [1239] Fix for #489 (secure session key). os.urandom is used when available.
  • [1249] WSGI improvements from Christian's cp3-wsgi-remix branch
  • [1287] Fix for #525 (Support Deleting Sessions).
  • [1288] Tweaks to docs, line lengths, tests, and number of serving lookups.
  • [1289] Fix for #428 (drop privileges).
  • [1310] Fix for #559 (allow config of WSGI middleware) via cherrypy.wsgi.pipeline.
  • [1313] Fix for # 255 (use output from tidy).
  • [1321] Fix for #556 (Allow error hooks to raise InternalRedirect?). As a bonus, all uncaught errors in Request.run now get a fallback handler (before only errors in handle_error got that).
  • [1323] session_auth really should NOT use thread_data.
  • [1337] New engine.autoreload_match attribute for filtering autoreload to a single package (adapted from TG).
  • [1388] Safer wsgi close in wsgiapps.
  • [1389] Fix for #481 (buildbot quiet mode). Use test.py --dumb to suppress the interactive test output features, as well as the "hit enter" prompt at the end. Also [1392] Final fix for #481 (buildbot). The test suite now exits with a non-zero code if any of the tests fail. See http://groups.google.com/group/cherrypy-devel/msg/e5c25c23484432d3
  • [1400] Applied suggested patch to #584 (Need a way to get the url submitted to a InternalRedirect?).

12/20/06 23:53:38: Modified by fumanchu

  • milestone changed from 3.0 to 2.2.2.

12/28/06 12:19:20: Modified by fumanchu

Per the IRC meeting today, here are the remaining backport candidates:

  • fumanchu [1166] RFC 2047 encoding/decoding of headers
  • dowski [1187] Caching should set Age header
  • fumanchu [1220] Fix for #438 (autoreload.py: Server fails to start if a .pyc is imported with no corresponding .py)
  • dowski [1239] Fix for #489 (secure session key). os.urandom is used when available.
  • Lawouach [1287] Fix for #525 (Support Deleting Sessions).
  • Lawouach [1323] session_auth really should NOT use thread_data.
  • fumanchu [1337] New engine.autoreload_match attribute for filtering autoreload to a single package (adapted from TG).
  • dowski [1388] Safer wsgi close in wsgiapps.
  • fumanchu [1389] Fix for #481 (buildbot quiet mode). Use test.py --dumb to suppress the interactive test output features, as well as the "hit enter" prompt at the end. Also [1392] Final fix for #481 (buildbot). The test suite now exits with a non-zero code if any of the tests fail. See http://groups.google.com/group/cherrypy-devel/msg/e5c25c23484432d3

All others (up to [1479]) are considered closed. Upgrade to 3.0 to get that functionality.

12/28/06 13:55:30: Modified by fumanchu

Ok, mine are done in [1566] - [1569]. Remaining:

  • dowski [1187] Caching should set Age header
  • dowski [1239] Fix for #489 (secure session key). os.urandom is used when available.
  • Lawouach [1287] Fix for #525 (Support Deleting Sessions).
  • Lawouach [1323] session_auth really should NOT use thread_data.
  • dowski [1388] Safer wsgi close in wsgiapps.

12/29/06 06:12:05: Modified by lawouach

Mine are done as well in [1583] and [1584]. Remaining:

  • dowski [1187] Caching should set Age header
  • dowski [1239] Fix for #489 (secure session key). os.urandom is used

when available.

  • dowski [1388] Safer wsgi close in wsgiapps.

12/29/06 10:06:12: Modified by dowski

  • status changed from assigned to closed.
  • resolution set to fixed.

I actually got mine done before Lawouach :p (he just updated the ticket first). Anyhow...

See [1576], [1577], [1578] and [1582].

Hosted by WebFaction

Log in as guest/cpguest to create tickets