Ticket #788 (enhancement)

I would like to suggest an enhancement of _checkBasicResponse() as shown by the following diff:

--- a/PyLib/CherryPy-3.1b1-py2.5.egg/cherrypy/lib/httpauth.py
+++ b/PyLib/CherryPy-3.1b1-py2.5.egg/cherrypy/lib/httpauth.py
@@ -309,7 +309,7 @@ def _checkDigestResponse(auth_map, password,
method = "GET", A1 = None, **kwargs
     return response == auth_map["response"]

 def _checkBasicResponse (auth_map, password, method='GET',
encrypt=None, **kwargs):
-    return encrypt(auth_map["password"]) == password
+    return encrypt(auth_map["password"], auth_map["username"]) ==
password

 AUTH_RESPONSES = {
     "basic": _checkBasicResponse,

The addition of a second parameter providing the user name to encrypt() would ease the life of cherrypy users writing an encryption function for basic http authentication. Because sometimes the encryption function needs additional information on how to encrypt the password, for example think about encrypting a password like Unix/ Linux does:

crypt.crypt(password, salt)

in which salt is the encrypted password which cannot guessed in the encryption function unless additional information is available like the corresponding user name.

Best regards, Sven