Ticket #935 (defect)
Opened 1 year ago
Last modified 1 year ago
Refactor wsgiserver to simplify the use of m2crypto (if one so chooses)
Status: closed (fixed)
| Reported by: | mihai.ibanescu@gmail.com | Assigned to: | fumanchu |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | CherryPy code | Keywords: | |
| Cc: |
The bind method of CherryPyWSGIServer is very monolithic. In my case, I have to use m2crypto instead of pyopenssl, and that means I have to override the whole function. If the function was broken down into logical steps, it would be much easier to achieve that.
Attached is a proposal (which also moves the dual-stack activation _before_ the SSL setup, see #871)
Attachments
Change History
06/22/09 10:12:52: Modified by mihai.ibanescu@gmail.com
- attachment wsgiserver.patch added.
06/22/09 10:31:33: Modified by mihai.ibanescu@gmail.com
- attachment wsgiserver.2.patch added.
08/02/09 16:03:32: Modified by fumanchu
- status changed from new to closed.
- resolution set to fixed.
- milestone set to 3.2.
Fixed in [2471] and following. The pyOpenSSL code has been moved to its own module; so has builtin ssl for Python 3 (and any backports). The separate modules are delegated to via a new CherryPyWSGIServer.ssl_adapter attribute, with bind and wrap methods. This should make it fairly simple to integrate M2Crypto. In fact, if a tested patch could be developed for M2Crypto, we'd very much like to distribute a module for it in the CherryPy distro.